[Ocfs2-tools-devel] [PATCH] fsck.ocfs2: clean up useless assignment in dup_insert()

[Eric Ren]

On 09/20/2016 09:23 PM, piaojun wrote:
> No need to assign for 'di' and 'dco' in dup_insert().
>
> Signed-off-by: Jun Piao <piaojun at huawei.com>

LGTM.

Reviewed-by: Eric Ren<zren at suse.com>

> ---
>   fsck.ocfs2/pass1b.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/fsck.ocfs2/pass1b.c b/fsck.ocfs2/pass1b.c
> index fc380ec..6edda58 100644
> --- a/fsck.ocfs2/pass1b.c
> +++ b/fsck.ocfs2/pass1b.c
> @@ -299,7 +299,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
>   	di = dup_inode_lookup(dct, dinode->i_blkno);
>   	if (!di) {
>   		dup_inode_insert(dct, new_di);
> -		di = new_di;
>   		new_di = NULL;
>   	}
>   
> @@ -312,7 +311,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
>   	}
>   	if (!dco) {
>   		list_add_tail(&new_dco->dco_list, &dc->dc_owners);
> -		dco = new_dco;
>   		new_dco = NULL;
>   	}
>   


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-tools-devel/attachments/20160921/0318138e/attachment.html