<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/20/2016 09:23 PM, piaojun wrote:<br>
</div>
<blockquote cite="mid:57E1385B.9050902@huawei.com" type="cite">
<pre wrap="">No need to assign for 'di' and 'dco' in dup_insert().
Signed-off-by: Jun Piao <a class="moz-txt-link-rfc2396E" href="mailto:piaojun@huawei.com"><piaojun@huawei.com></a></pre>
</blockquote>
<pre wrap="">LGTM.
Reviewed-by: Eric Ren <a class="moz-txt-link-rfc2396E" href="mailto:zren@suse.com"><zren@suse.com></a></pre>
<blockquote cite="mid:57E1385B.9050902@huawei.com" type="cite">
<pre wrap="">
---
fsck.ocfs2/pass1b.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fsck.ocfs2/pass1b.c b/fsck.ocfs2/pass1b.c
index fc380ec..6edda58 100644
--- a/fsck.ocfs2/pass1b.c
+++ b/fsck.ocfs2/pass1b.c
@@ -299,7 +299,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
di = dup_inode_lookup(dct, dinode->i_blkno);
if (!di) {
dup_inode_insert(dct, new_di);
- di = new_di;
new_di = NULL;
}
@@ -312,7 +311,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
}
if (!dco) {
list_add_tail(&new_dco->dco_list, &dc->dc_owners);
- dco = new_dco;
new_dco = NULL;
}
</pre>
</blockquote>
<p><br>
</p>
</body>
</html>