[Ocfs2-tools-devel] [PATCH] fsck.ocfs2: clean up useless assignment in dup_insert()
Joseph Qi
joseph.qi at huawei.com
Tue Sep 20 20:10:57 PDT 2016
Reviewed-by: Joseph Qi <joseph.qi at huawei.com>
On 2016/9/20 21:23, piaojun wrote:
> No need to assign for 'di' and 'dco' in dup_insert().
>
> Signed-off-by: Jun Piao <piaojun at huawei.com>
> ---
> fsck.ocfs2/pass1b.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fsck.ocfs2/pass1b.c b/fsck.ocfs2/pass1b.c
> index fc380ec..6edda58 100644
> --- a/fsck.ocfs2/pass1b.c
> +++ b/fsck.ocfs2/pass1b.c
> @@ -299,7 +299,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
> di = dup_inode_lookup(dct, dinode->i_blkno);
> if (!di) {
> dup_inode_insert(dct, new_di);
> - di = new_di;
> new_di = NULL;
> }
>
> @@ -312,7 +311,6 @@ static errcode_t dup_insert(struct dup_context *dct, uint32_t cluster,
> }
> if (!dco) {
> list_add_tail(&new_dco->dco_list, &dc->dc_owners);
> - dco = new_dco;
> new_dco = NULL;
> }
>
>
More information about the Ocfs2-tools-devel
mailing list