[Ocfs2-tools-devel] debufs.ocfs2: issue cat command against some of the system files cause core dump

[jeff.liu]

Hi Tao,

Thanks for your hints, by adding the file check function in dump_file,
the corresponding commands works well for me.
The patch was attached.



Regards,
Jeff


Tao Ma 写道:
> Hi Jeff,
> 	thanks for the info. but I think maybe we need to eliminate all the
> scenario. At least dump also have the same bug.
>
> debugfs: dump //global_bitmap /tmp/1
> debugfs.ocfs2: extend_file.c:211: ocfs2_new_path: Assertion
> `root_el->l_tree_depth < 5' failed.
>
> rdump should have the same problem.
>
> So maybe you need to add the check in dump_file to prevent all these.
>
> Regards,
> Tao
>
> jeff.liu wrote:
>   
>> Hello,
>>
>> issue command 'cat' against some of the OCFS2 system files in
>> debugfs.ocfs2 cause core dump.
>> for example:
>> -----------
>> debugfs.ocfs: cat //global_bitmap
>> debugfs.ocfs2: extend_file.c:211: ocfs2_new_path: Assertion
>> `root_el->l_tree_depth < 5' failed.
>> Aborted (core dumped)
>>
>> looks the command get some unexpected data just cause the assertion
>> failed. :(
>>
>> I am wonder whether the system files could be cat or not, the patch
>> checking if the target to cat is a system file, if yes, just return and
>> show user
>> the related message.
>>
>>
>> Thanks,
>> Jeff
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Ocfs2-tools-devel mailing list
>> Ocfs2-tools-devel at oss.oracle.com
>> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
>>     

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ocfs2-tools-add-system-file-type-check-for-debugfs.patch
Type: text/x-diff
Size: 1016 bytes
Desc: not available
Url : http://oss.oracle.com/pipermail/ocfs2-tools-devel/attachments/20090317/c50be678/attachment.bin