[Ocfs2-tools-devel] debufs.ocfs2: issue cat command against some of the system files cause core dump

[Sunil Mushran]

cat/dump/rdump are for regular files only. Looks like we are missing a
check.

On Tue, Mar 17, 2009 at 05:00:15PM +0800, Tao Ma wrote:
> Hi Jeff,
> 	thanks for the info. but I think maybe we need to eliminate all the
> scenario. At least dump also have the same bug.
> 
> debugfs: dump //global_bitmap /tmp/1
> debugfs.ocfs2: extend_file.c:211: ocfs2_new_path: Assertion
> `root_el->l_tree_depth < 5' failed.
> 
> rdump should have the same problem.
> 
> So maybe you need to add the check in dump_file to prevent all these.
> 
> Regards,
> Tao
> 
> jeff.liu wrote:
> > Hello,
> > 
> > issue command 'cat' against some of the OCFS2 system files in
> > debugfs.ocfs2 cause core dump.
> > for example:
> > -----------
> > debugfs.ocfs: cat //global_bitmap
> > debugfs.ocfs2: extend_file.c:211: ocfs2_new_path: Assertion
> > `root_el->l_tree_depth < 5' failed.
> > Aborted (core dumped)
> > 
> > looks the command get some unexpected data just cause the assertion
> > failed. :(
> > 
> > I am wonder whether the system files could be cat or not, the patch
> > checking if the target to cat is a system file, if yes, just return and
> > show user
> > the related message.
> > 
> > 
> > Thanks,
> > Jeff
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Ocfs2-tools-devel mailing list
> > Ocfs2-tools-devel at oss.oracle.com
> > http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
> 
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel