[Ocfs2-tools-devel] [PATCH 03/39] umount.ocfs2: Add umount.ocfs2 to pair mount.ocfs2

[Joel Becker]

On Thu, May 15, 2008 at 03:14:20PM -0700, Sunil Mushran wrote:
> Nice patch. Small quibble though. But small enough for a sign off.

	Actually, that's intended - see below.

> Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
>
> Joel Becker wrote:
>> +
>> +	rc = -ENOSYS;
>> +	if (mo.flags) {
>>   
>
> if (mo.flags & MNT_DETACH) {
>
>> +		rc = umount2(mo.dir, mo.flags);

	We actually want the original code, because we can add MNT_FORCE
later.  Basically, any flags require umount2(2), but if there are no
flags we can skip right to umount(2).  So this is future-proof.

Joel

-- 

Life's Little Instruction Book #313

	"Never underestimate the power of love."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127