[Ocfs2-tools-devel] [PATCH 03/39] umount.ocfs2: Add umount.ocfs2 to pair mount.ocfs2

[Sunil Mushran]

Fair enough. But I want to hold off on my signoff till we don't resolve
the bind mounts v heartbeat issue.

ocfs2-tools-devel subscribers:
The issue is that umount.ocfs2 is called for all umounts, the first of
which will result in a stop hearbeat in the new scheme, even if there
are active bind mounts.

Joel will discuss this with Al Viro.

Time to revive global heartbeat? :)

Joel Becker wrote:
> On Thu, May 15, 2008 at 03:14:20PM -0700, Sunil Mushran wrote:
>   
>> Nice patch. Small quibble though. But small enough for a sign off.
>>     
>
> 	Actually, that's intended - see below.
>
>   
>> Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
>>
>> Joel Becker wrote:
>>     
>>> +
>>> +	rc = -ENOSYS;
>>> +	if (mo.flags) {
>>>   
>>>       
>> if (mo.flags & MNT_DETACH) {
>>
>>     
>>> +		rc = umount2(mo.dir, mo.flags);
>>>       
>
> 	We actually want the original code, because we can add MNT_FORCE
> later.  Basically, any flags require umount2(2), but if there are no
> flags we can skip right to umount(2).  So this is future-proof.
>
> Joel
>
>