[Ocfs2-tools-devel] [PATCH 03/39] umount.ocfs2: Add umount.ocfs2 to pair mount.ocfs2

[Sunil Mushran]

Nice patch. Small quibble though. But small enough for a sign off.
 
Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>


Joel Becker wrote:
> +
> +	if (clustered) {
> +		ret = o2cb_init();
> +		if (ret) {
> +			com_err(progname, ret, "Cannot initialize cluster");
> +			goto bail;
> +		}
> +	}
> +
> +	block_signals (SIG_BLOCK);
> +
> +	rc = -ENOSYS;
> +	if (mo.flags) {
>   

if (mo.flags & MNT_DETACH) {

> +		rc = umount2(mo.dir, mo.flags);
> +		if (rc) {
> +			rc = -errno;
> +			fprintf(stderr, "Error calling umount2(): %s",
> +				strerror(-rc));
> +			if ((rc == -ENOSYS) && verbose)
> +				fprintf(stdout,
> +					"No umount2(), trying umount()...\n");
> +		}
> +	}
> +	if (rc == -ENOSYS) {
> +		rc = umount(mo.dir);
> +		if (rc) {
>