[DTrace-devel] [PATCH 2/5] test: Remove xfail marker from tst.keysort.d

[Kris Van Hees]

On Wed, Sep 07, 2022 at 11:22:57AM -0400, Eugene Loh via DTrace-devel wrote:
> r-b Eugene
> But shouldn't this be squashed into the (preceding) patch that provides
> setopt()?
> Specifically, that would give the setopt() patch an accompanying test.

Yes, but the keysort test is too specific to one set of options whereas the
setopt() implementation is really the core support.  Various options may need
additional patches to implement them properly, on top of setopt.

> On 9/6/22 21:36, Kris Van Hees via DTrace-devel wrote:
> > With setopt() support, this test should work.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   test/unittest/aggs/tst.keysort.d | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/test/unittest/aggs/tst.keysort.d b/test/unittest/aggs/tst.keysort.d
> > index ef01a0a3..31b95088 100644
> > --- a/test/unittest/aggs/tst.keysort.d
> > +++ b/test/unittest/aggs/tst.keysort.d
> > @@ -6,7 +6,6 @@
> >    */
> >   /* @@nosort */
> > -/* @@xfail: need setopt() support */
> >   #pragma D option quiet
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel