[DTrace-devel] [PATCH 2/5] test: Remove xfail marker from tst.keysort.d

Eugene Loh eugene.loh at oracle.com
Wed Sep 7 15:22:57 UTC 2022


r-b Eugene
But shouldn't this be squashed into the (preceding) patch that provides 
setopt()?
Specifically, that would give the setopt() patch an accompanying test.

On 9/6/22 21:36, Kris Van Hees via DTrace-devel wrote:
> With setopt() support, this test should work.
>
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   test/unittest/aggs/tst.keysort.d | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/test/unittest/aggs/tst.keysort.d b/test/unittest/aggs/tst.keysort.d
> index ef01a0a3..31b95088 100644
> --- a/test/unittest/aggs/tst.keysort.d
> +++ b/test/unittest/aggs/tst.keysort.d
> @@ -6,7 +6,6 @@
>    */
>   
>   /* @@nosort */
> -/* @@xfail: need setopt() support */
>   
>   #pragma D option quiet
>   



More information about the DTrace-devel mailing list