[rds-devel] [git pull] quick fixes

Andy Grover andy.grover at oracle.com
Tue Jul 13 14:45:43 PDT 2010


Looks pretty good to me. How about a comment somewhere about the whole 
signaled/unsignaled issue? Putting the "if (nr_sig) add_" bit in a 
rds_ib_add_signaled function to match _sub_ could also be nice.

It's gonna be so pleasant to have working rmmod!

Merged the __init cset, pushed up to devel.

Thanks -- Regards -- Andy

On 07/13/2010 12:36 PM, Zach Brown wrote:
>> Maybe we can add a little bookkeeping to wait just until all
>> signaled WRs are done?
>
> OK, I gave this a try and it looks pretty good.  It stops the crash
> in testing over here.  What do you think?
>
> It looks like the init and exit annotation removal isn't in the devel
> branch on oss so I'm still carrying it.
>
> - z
>
> The following changes since commit
> ad380e8a5101d2579b849f7e383121ebff261444: Andy Grover (1): RDS/IB:
> Use SLAB_HWCACHE_ALIGN flag for kmem_cache_create()
>
> are available in the git repository at:
>
> git://oss.oracle.com/git/zab/ofed-1.5-linux-2.6.git
> devel-fixes-jul-13-2010
>
> Zach Brown (2): RDS: remove __init and __exit annotation RDS/IB:
> track signaled sends
>
> net/rds/af_rds.c         |    4 ++-- net/rds/connection.c     |    2
> +- net/rds/ib.c             |    2 +- net/rds/ib.h             |   11
> ++++++----- net/rds/ib_cm.c          |   10 +++++-----
> net/rds/ib_rdma.c        |    4 ++-- net/rds/ib_recv.c        |    2
> +- net/rds/ib_send.c        |   42
> +++++++++++++++++++++++++++++++++++++----- net/rds/ib_sysctl.c      |
> 2 +- net/rds/iw.c             |    2 +- net/rds/iw.h             |
> 6 +++--- net/rds/iw_recv.c        |    2 +- net/rds/iw_sysctl.c
> |    2 +- net/rds/rdma_transport.c |    4 ++-- net/rds/rds.h
> |   10 +++++----- net/rds/stats.c          |    2 +- net/rds/sysctl.c
> |    2 +- net/rds/tcp.c            |    2 +- net/rds/tcp.h
> |    6 +++--- net/rds/tcp_listen.c     |    2 +- net/rds/tcp_recv.c
> |    2 +- net/rds/threads.c        |    2 +- 22 files changed, 78
> insertions(+), 45 deletions(-)
>
>




More information about the rds-devel mailing list