[Ocfs2-users] o2cb stack and kernel >= 2.6.37

[Sunil Mushran]

On 04/04/2011 10:08 AM, Jacek Stępniewski wrote:
> At protocol negotiation 1.0 is selected (rest of nodes are pre 2.6.37 with dlm 1.0).
> But connecting node (with kernel>= 2.6.37) checks builtin version, not negotiated one.
> I have found this code in dlmdomain.c:1615 (function: dlm_try_to_join_domain)
>
>         /* Support for global heartbeat and node info was added in 1.1 */
>         if (dlm_protocol.pv_major>  1 || dlm_protocol.pv_minor>  0) {
>                  status = dlm_send_nodeinfo(dlm, ctxt->yes_resp_map);
>
> dlm_protocol is not changed during negotiation
> I think here should be dlm->dlm_locking_proto instead dlm_protocol
>
> This leads to sending unknown message type DLM_QUERY_NODEINFO (unknown for protocol 1.0):
>
> (mount.ocfs2,10247,3):dlm_send_nodeinfo:1235 ERROR: node mismatch -92, node 3
> (mount.ocfs2,10247,3):dlm_try_to_join_domain:1618 ERROR: status = -92
> (mount.ocfs2,10247,3):dlm_join_domain:1879 ERROR: status = -92
>
> This code exists (in git) up to 2.6.39-rc1

oops. You are correct. If you want, you can send in a patch fix.
Else, I can do it later today. Send it to ocfs2-devel at oss.oracle.com.