[Ocfs2-devel] RE: [Ocfs2-users] RE: Playing with OCFS2
Mark Fasheh
mark.fasheh at oracle.com
Mon Feb 2 15:59:07 CST 2004
Ahh, good catch! I removed those lines of code as that check is not really
needed (it's simple enough to follow). Thanks!
--Mark
On Mon, Feb 02, 2004 at 03:13:39PM -0800, Villalovos, John L wrote:
> Enclosed please find a patch which fixes the issue I had.
>
> The root cause is that spin_trylock will always return 1 on a
> Uniprocessor (UP) system.
>
> It appears the code in this case had an assumption of a SMP system. The
> spin_trylock appears to be used as a debugging mechanism to make sure
> that a lock had been previously made before the function was called.
>
> My patch is just to use the #ifdef CONFIG_SMP but I think that this may
> go against the kernel guidelines but I am not sure.
>
> John
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh at oracle.com
More information about the Ocfs2-users
mailing list