[Ocfs2-tools-devel] [PATCH] discard unused blocks before mkfs

[Larry Chen]

Hi Joseph,

On 02/24/2018 03:19 PM, Joseph Qi wrote:
>
> On 18/2/24 12:40, Changwei Ge wrote:
>> Hi Larry,
>> I have some quick questions:
>> 1) It seems that your patch doesn't check if the backing disk is SSD or not, is
>> that reasonable?
>> 2) Why not just trim SSD before 'mkfs' performed by users? It's more
>> straightforward.
> I'd like doing discard during mkfs, just like ext4 behaves.
> But I suggest we give an option to allow user to skip this operation,
> since discard is really heavy.
> We can take some inspiration from mke2fs.
Yeah, mke2fs is a good reference for this patch.
I'll modify this patch to provide users with an option to decide whether 
discard operations will be executed.
>
> Thanks,
> Joseph
>
>> 3) Could you share some statistics telling the degree performance boosted.
>>