[Ocfs2-tools-devel] [PATCH] discard unused blocks before mkfs

[Gang He]

>>> 

> 
> On 18/2/24 12:40, Changwei Ge wrote:
>> Hi Larry,
>> I have some quick questions:
>> 1) It seems that your patch doesn't check if the backing disk is SSD or not, 
> is 
>> that reasonable?
>> 2) Why not just trim SSD before 'mkfs' performed by users? It's more 
>> straightforward.
> I'd like doing discard during mkfs, just like ext4 behaves.
> But I suggest we give an option to allow user to skip this operation,
> since discard is really heavy.
> We can take some inspiration from mke2fs.
True, this idea is from ext file system.
I agree to give a option to the user, to tell mkfs to skip trim operation before format ocfs2 file system.
Of course, we need to check if the underlying disk support trim operation firstly, if not, just do nothing.

Thanks
Gang

> 
> Thanks,
> Joseph
> 
>> 3) Could you share some statistics telling the degree performance boosted.
>>