[Ocfs2-tools-devel] [PATCH 0/5] O2info: Adding all the rest of running codes to o2info.

[Sunil Mushran]

So you can add my reviewed-by.

But it needs more work. The main thing is that the code layout is too tied
to the output. For example, I would rather the code get all the superblock
info and then let the output limit the printing to what is required. Currently
it reads exactly what is asked and that makes the code larger but does not
make it any more efficient. Smaller code == better, especially for utils like
this. The tool I am thinking of is debugfs. It separates the read and the
display like I have tried to explain above.

Check it in. I'll have to play around with it before I can make any suggestions
on the argument restructuring.

Thanks

On 06/03/2011 12:10 AM, Tristan Ye wrote:
> This patch series keeps tools the same pace with o2info kernel part, and tries
> to make the o2info a complete utility according to original design doc for the
> first time, with following codes being added:
>
> 	* --freeinode
>    	* --freefrag
> 	* --space-usage
> 	* --filestat
>
> It has been in following remote branch:
>
> git://oss.oracle.com/git/tye/ocfs2-tools.git o2info
>
> I believe most of following patches have already got SOB, and it's a good time
> to push them upstream into ocfs2-tools.git central repo since kernel part has
> been in mainline for a while.
>
> Tristan
>
>
>
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel