[Ocfs2-tools-devel] [PATCH 0/5] O2info: Adding all the rest of running codes to o2info.

[Tristan Ye]

Sunil Mushran wrote:
> On 06/03/2011 04:33 PM, Joel Becker wrote:
>> On Fri, Jun 03, 2011 at 04:23:31PM -0700, Sunil Mushran wrote:
>>> e.g.,
>>> This is lot more efficient...
>>> numslots=$(o2info volinfo -N [-d DEVICE] FILE)
>>> than...
>>> numslots=$(o2info --volinfo DEVICE | awk '/Node Slots:/ { print $3; }')
>>     Are you proposing that each command have an arbitrary number of
>> switches (-N, -L, etc)?
> 
> Yes.
> 
> # o2cb volinfo --mkfs [-d DEVICE] [FILE]
> will print the output in mkfs format.
> 
> # o2cb volinfo [-d DEVICE] [FILE]
> will print default format
> 
> #o2cb volinfo --fs-features [-d DEVICE] [FILE]
> only features...
Sunil,
	So my suggestion is to push these patches upstream first, since they're mostly
about the 'freefrag' and 'freeinode' things, which keeps a series with former
committed patches. the commands you're talking most were actually in central
repo for a while, the refactoring therefore will be another patches series to
change the whole style, what you think?

Tristan


> 
> etc.