[Ocfs2-tools-devel] [PATCH 15/15] dx_dirs v10: enable metaecc and indexed-dirs support as default features

[Sunil Mushran]

Mark Fasheh wrote:
> On Thu, Mar 25, 2010 at 03:52:22AM +0800, Coly Li wrote:
>> metaecc feature enables ECC checking for meta data, which helps the file
>> system consistency. indexed-dirs feature enables indexed tree for
>> directories, which improves lookup performance for large scale
>> directories.
>>
>> This patch enables metaecc and indexed-dirs support as default features.
> Nice patch, but not yet :)  We should let the dx_dir patches get some testing
> in ocfs2-tools.git first - Sunil in particular had mentioned that to me earlier.
>
> Regarding metaecc, I'm not sure if we ever intended that to be enabled by
> default as it uses more cpu when enabled. That said, cpus are so fast these
> days..


Many users are waiting for dx_dirs. So I am sure we'll get quick feedback.

http://oss.oracle.com/bugzilla/show_bug.cgi?id=1214
With metaecc, we had this case above. Yes, it was a user-error that led
to it. But we have to have a cleaner way out of it. As in, we should not
expect users to hand edit the superblock to disable metaecc.

I am still puzzled as to how the backups went bad.