[Ocfs2-tools-devel] [PATCH 4/8] O2info: Add running codes for '--volinfo'.

[Joel Becker]

On Wed, Apr 21, 2010 at 10:09:35AM -0700, Sunil Mushran wrote:
> Yes, I meant keeping the output to within 80 chars. It is easier to read.
> 
> If you were to do the three separately, it would look like this.
> Features : backup-super strict-journal-super
> Features : local sparse extended-slotmap inline-data metaecc xattr refcount
> Features : unwritten usrquota grpquota
> 
> With the way I have suggested, it would look like this.
> Features : backup-super strict-journal-super local sparse extended-slotmap
> Features : inline-data metaecc xattr refcount unwritten usrquota grpquota
> 
> The advantage in the second scheme is that we can keep adding features and
> the output will balance itself. And this costs us just a few extra lines of
> code.

	Sunil is right, there is no need to differentiate
compat/incompat/rocompat here.  The user can read the docs if they care.
We're just displaying the feature set for them.

Joel

-- 

Life's Little Instruction Book #450

	"Don't be afraid to say, 'I need help.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127