[Ocfs2-tools-devel] [PATCH 4/8] O2info: Add running codes for '--volinfo'.

[Sunil Mushran]

tristan wrote:
> Sunil Mushran wrote:
>   
>> I see no reason why the features is also not part of volinfo. We can have
>> a separate fs-features option too. I like this because we get all the 
>> info
>> in one place.
>>
>> The output should look like this.
>>
>> Label : label-max1
>> UUID : 81AC29CCF77C4F16A49022AE20A56D8B
>> Block Size : 4096
>> Cluster Size : 4096
>> Node Slots : 8
>> Features : backup-super strict-journal-super sparse extended-slotmap
>> Features : metaecc xattr refcount unwritten
>>     
>
> So why not dividing the features into three lines(compat, incompat and 
> ro-compat), and we can hide such rule from end-user.
>
>
> For breaking it into multiple lines, did you mean we determine the lines 
> by cutting featues to less-than-80-chars lines?

Yes, I meant keeping the output to within 80 chars. It is easier to read.

If you were to do the three separately, it would look like this.
Features : backup-super strict-journal-super
Features : local sparse extended-slotmap inline-data metaecc xattr refcount
Features : unwritten usrquota grpquota

With the way I have suggested, it would look like this.
Features : backup-super strict-journal-super local sparse extended-slotmap
Features : inline-data metaecc xattr refcount unwritten usrquota grpquota

The advantage in the second scheme is that we can keep adding features and
the output will balance itself. And this costs us just a few extra lines of
code.