[Ocfs2-tools-devel] [PATCH 13/15] dx_dirs v11: try to install dir trailers when enable indexed-dirs

[Coly Li]

On 04/20/2010 07:52 AM, Joel Becker Wrote:
> On Sun, Apr 11, 2010 at 04:10:10PM +0800, Coly Li wrote:
>> @@ -529,9 +510,9 @@ out:
>>  }
>>  
>>  
>> -static errcode_t tunefs_install_dir_trailer(ocfs2_filesys *fs,
>> -					    struct ocfs2_dinode *di,
>> -					    struct tunefs_trailer_context *tc)
>> +errcode_t tunefs_install_dir_trailer(ocfs2_filesys *fs,
>> +					struct ocfs2_dinode *di,
>> +					struct tunefs_trailer_context *tc)
>>  {
>>  	errcode_t ret = 0;
>>  	struct tunefs_trailer_context *our_tc = NULL;
> 
> 	If you are moving tunefs_install_dir_trailer() to be a shared
> function, it belongs in libocfs2ne.c.  You should move the function
> there, just like you moved the prototype to libocfs2ne.h.
> 

At the first time I didn't do this was because several other local routines had to be moved from feature_metaecc.c to
libocfs2ne.c, and I though this modified too much.

An extra patch for the movement will be posted out soon. Thanks for your review.

-- 
Coly Li
SuSE Labs