[Ocfs2-tools-devel] [PATCH 13/15] dx_dirs v11: try to install dir trailers when enable indexed-dirs

[Joel Becker]

On Sun, Apr 11, 2010 at 04:10:10PM +0800, Coly Li wrote:
> @@ -529,9 +510,9 @@ out:
>  }
>  
>  
> -static errcode_t tunefs_install_dir_trailer(ocfs2_filesys *fs,
> -					    struct ocfs2_dinode *di,
> -					    struct tunefs_trailer_context *tc)
> +errcode_t tunefs_install_dir_trailer(ocfs2_filesys *fs,
> +					struct ocfs2_dinode *di,
> +					struct tunefs_trailer_context *tc)
>  {
>  	errcode_t ret = 0;
>  	struct tunefs_trailer_context *our_tc = NULL;

	If you are moving tunefs_install_dir_trailer() to be a shared
function, it belongs in libocfs2ne.c.  You should move the function
there, just like you moved the prototype to libocfs2ne.h.

Joel

-- 

"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127