[Ocfs2-tools-devel] [PATCH 1/1] Ocfs2-tools: Ocfs2-tools: Let debugfs.ocfs2 correctly (r)dump the fast symlink v2.

[tristan.ye]

On Wed, 2009-06-03 at 18:44 -0700, Sunil Mushran wrote:
> tristan.ye wrote:
> >> In dump_file(), just call rdump_symlink()... that is after 
> >> read_cached_inode().
> >> The current code does not look right. Hint: Use ci_inode.
> >
> > Just a little bit confused,  why we have to call rdump_symlink() here,
> > the existing-code's logic is to dump the symlink's(for none-fast
> > symlinks) real content. so you mean the currrent logic of dump cmd for
> > none-fast symlinks was not correct?
> 
> So dump_file() does not seem to handle links at all. Can you quickly
> test that?

The dump_file() can handle the none-fast symlinks according to my
testing.
it can successfully dump the symlink's destination path into the target
file when we do

dump -p <none-fast symlink> <target>

> 
> I suggested calling rdump_symlink() because that's what we want.
> BTW, rdump_symlink() does not do rdump(). Maybe we rename it to
> dump_symlink() as that is what is is doing.

rdump_symlink() will not dump symlink's content but do another
symlink(2) to the target instead, so it was a different logic compared
to dump_file() when they handling symlinks. we may need a unification
here...


Tristan.