[Ocfs2-tools-devel] [PATCH 1/1] Ocfs2-tools: Ocfs2-tools: Let debugfs.ocfs2 correctly (r)dump the fast symlink v2.

Sunil Mushran sunil.mushran at oracle.com
Wed Jun 3 18:44:04 PDT 2009


tristan.ye wrote:
>> In dump_file(), just call rdump_symlink()... that is after 
>> read_cached_inode().
>> The current code does not look right. Hint: Use ci_inode.
>
> Just a little bit confused,  why we have to call rdump_symlink() here,
> the existing-code's logic is to dump the symlink's(for none-fast
> symlinks) real content. so you mean the currrent logic of dump cmd for
> none-fast symlinks was not correct?

So dump_file() does not seem to handle links at all. Can you quickly
test that?

I suggested calling rdump_symlink() because that's what we want.
BTW, rdump_symlink() does not do rdump(). Maybe we rename it to
dump_symlink() as that is what is is doing.



More information about the Ocfs2-tools-devel mailing list