[Ocfs2-tools-devel] [Ocfs2-devel] [PATCH 3/8] Implement quota functions to libocfs2

[Jan Kara]

On Tue 28-07-09 15:52:45, Joel Becker wrote:
> On Tue, Jul 28, 2009 at 12:08:29PM +0200, Jan Kara wrote:
> > +/* Read given block */
> > +static errcode_t read_blk(ocfs2_filesys *fs, int type, uint blk, char *buf)
> 
> 	You're sure quota files will never be larger than a uint?  Also,
> we tend to do 'unsigned int', not 'uint'.
  Well, the disk format is designed only for 32-bit uids and gids (which is
consistent with the rest of OCFS2). For 2^32 users tracked in the quota file,
it is going to have around 2^29 blocks so yes, unsigned int should be safe
:)
  I'll substitute uint with unsigned int... although it's horribly long for
such a useful type ;).

									Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR