[Ocfs2-tools-devel] [Ocfs2-devel] [PATCH 3/8] Implement quota functions to libocfs2

Joel Becker Joel.Becker at oracle.com
Tue Jul 28 15:52:45 PDT 2009


On Tue, Jul 28, 2009 at 12:08:29PM +0200, Jan Kara wrote:
> +/* Read given block */
> +static errcode_t read_blk(ocfs2_filesys *fs, int type, uint blk, char *buf)

	You're sure quota files will never be larger than a uint?  Also,
we tend to do 'unsigned int', not 'uint'.

Joel

-- 

"When I am working on a problem I never think about beauty. I
 only think about how to solve the problem. But when I have finished, if
 the solution is not beautiful, I know it is wrong."
         - Buckminster Fuller

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list