[Ocfs2-tools-devel] [RFC] fsck.ocfs2: Make extent list check prompt more generic.

Tao Ma tao.ma at oracle.com
Wed Dec 2 19:09:50 PST 2009



Joel Becker wrote:
> On Mon, Nov 30, 2009 at 10:35:56PM +0800, Tao Ma wrote:
>> So we'd better make the check of extent list more generic.
>> This patch removes the old usage of "inode" and di->i_blkno.
>> We pass an owner instead like we do in the kernel.
>> I just don't know whether it is OK for the user to see the
>> word "tree" instead of "inode". Will they get puzzled by it?
> 
> 	This looks good, but it's better to say "owner" rather than
> "tree".  That's what I did in the metadata cache work.  I changed "Inode
> %llu has bad extent block %llu" to "Owner %llu has bad extent block
> %%llu", etc.
yeah, I am just now sure whether the word "owner" does mean something 
for the user. anyway, since we use owner in the kernel log, I will use 
it also in fsck prompt.

Thanks for the review.

Regards,
Tao



More information about the Ocfs2-tools-devel mailing list