[Ocfs2-tools-devel] [RFC] fsck.ocfs2: Make extent list check prompt more generic.

Joel Becker Joel.Becker at oracle.com
Wed Dec 2 18:20:41 PST 2009


On Mon, Nov 30, 2009 at 10:35:56PM +0800, Tao Ma wrote:
> So we'd better make the check of extent list more generic.
> This patch removes the old usage of "inode" and di->i_blkno.
> We pass an owner instead like we do in the kernel.
> I just don't know whether it is OK for the user to see the
> word "tree" instead of "inode". Will they get puzzled by it?

	This looks good, but it's better to say "owner" rather than
"tree".  That's what I did in the metadata cache work.  I changed "Inode
%llu has bad extent block %llu" to "Owner %llu has bad extent block
%%llu", etc.

Joel

-- 

"In a crisis, don't hide behind anything or anybody. They're going
 to find you anyway."
	- Paul "Bear" Bryant

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list