[Ocfs2-tools-devel] [PATCH 6/6] libocfs2: add set and get xattr operations

[Tiger Yang]

Tao Ma wrote:

>> -#define OCFS2_XATTR_ROOT_SIZE    (sizeof(struct 
>> ocfs2_xattr_def_value_root))
> you added it above whild deleting it here? So maybe don't change its line?

I just want to put all marcos together.


> I will trust you for coping xattr functions from kernel to userspace. 
> And I just skimmed it, it looks well but I am afraid you have to change 
> some comments since there are so many "bh" things.

OK, will correct them next.

>> +errcode_t ocfs2_xattr_name_iterate(ocfs2_cached_inode *ci,
>> +                   int (*func)(ocfs2_cached_inode *ci,
>> +                        const char *name,
>> +                        void *priv_data),
>> +                   void *priv_data)
>> +{
>> +    errcode_t ret = 0;
>> +    return ret;
>> +}
> What's this?
Oh, forget remove this.

thanks,
tiger