[Ocfs2-tools-devel] [PATCH 2/6] libocfs2: extend xattr and xattr value tree

[Tiger Yang]

Tao Ma wrote:

> Oh, I see you change the prototype and now it isn't xattr related. 
> Perfect. But maybe we can rename it to ocfs2_find_leaf like we do in the 
> kernel?

OK, will change it.

>> +errcode_t ocfs2_tree_insert_extent(ocfs2_cached_inode *ci,
>> +                   uint32_t cpos, uint64_t c_blkno,
>> +                   uint32_t clusters, uint16_t flag,
>> +                   struct ocfs2_extent_tree *et)
> I guess this function is 90% similar to 
> ocfs2_cached_inode_insert_extent. Any reason you want to copy it? In 
> kernel, we only have one ocfs2_insert_extent.

ocfs2_cached_inode_insert_extent is well tested, but xattr stuff is not,
I don't want to ruin inode tree with a new function, so I use 
tree_insert handle xattr tree, perhaps we can merge them after some test 
and review.

Thanks,
tiger