[Ocfs2-tools-devel] [PATCH 9/9] ocfs2-tools: add xattr support in tunefs.ocfs2

[Tiger Yang]

Joel Becker wrote:
> 	This really could be called ocfs2_extent_iterate_xattr_value(),
> you know?  Just like extent_iterate_inode below it.
> 	This never writes out the buffer containing the
> ocfs2_extent_list.  Now, in this patch we are just deleting the entire
> xattr set, so that's not necessary.  But this function should be the
> generic ocfs2_extent_iterate_xattr_value(), and it should write out the
> block if changed.  Or perhaps let the caller know to do so.

OK. fix them in the next version.

> 	This removes the buckets, but it doesn't remove the extent
> blocks that make up the xattr index tree.  Those need to get removed.
That extent block be freed in remove_xattr_block() by 
ocfs2_delete_xattr_block().

> 	The 'interact' strings are most likely to be seen.  Let's say
> "extended attributes" instead of "xattr" in those strings.

OK. got it.

Thanks,
tiger