[Ocfs2-tools-devel] [PATCH 0/9] ocfs2-tools: add xattr support in ocfs2-tools v2

[Joel Becker]

On Fri, Dec 19, 2008 at 05:32:53PM +0800, Tiger Yang wrote:
> Hi, Joel,
>
> There are 9 patches add xattr support in ocfs2-tools. They are based on  
> metaecc branch.

	A quick overview comment before I finish reviewing the set.
There are some places that the API in libocfs2 is incomplete.  There's
no bucket management, and there is no ocfs2_xattr_list(),
ocfs2_xattr_get(), or ocfs2_xattr_set().  All the tools basically
hand-manage raw xattr structures.  I'd hoped to see a little more API.
	However, this patch series does create a completely usable tool
set for xattr support.  I haven't looked at fsck and tunefs yet, but if
they are like mkfs and debugfs, they will be perfectly workable, enough
to use the feature in the filesystem.  I don't see any reason to
postpone usable xattrs.
	So, I think we should push these patches upstream after any
cleanups proposed for each patch (I have a few comments).  This will
give us tools that support xattrs and allow users to try them out.  We
can then focus on expanding the API and such on top of this work.

Joel

-- 

"Well-timed silence hath more eloquence than speech."  
         - Martin Fraquhar Tupper

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127