[Ocfs2-tools-devel] [patch 1/8] Adds some macros in the header files, take 2

Joel Becker Joel.Becker at oracle.com
Mon Jun 18 17:11:46 PDT 2007


On Mon, Jun 18, 2007 at 04:56:25PM -0700, Mark Fasheh wrote:
> We're missing one thing though - I believe you need to add a check against
> s_tunefs_flag in ocfs2_open() if the OCFS2_FLAG_STRICT_COMPAT_CHECK flag is passed. That way
> fsck.ocfs2 won't try to clean up an aborted tunefs that it doesn't know
> about.

	Yes, absolutely.  Just like INCOMPAT flags, an fsck.ocfs2 must
know all the existing s_tunefs_flags it sees before it can continue.

Joel

-- 

"Three o'clock is always too late or too early for anything you
 want to do."
        - Jean-Paul Sartre

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list