[Ocfs2-tools-devel] [patch 1/8] Adds some macros in the header files, take 2

[Mark Fasheh]

On Fri, Jun 15, 2007 at 04:15:30PM +0800, tao.ma at oracle.com wrote:
> Add macro "OCFS2_FEATURE_INCOMPAT_TUNEFS_INPROG" in ocfs2_fs.h to protect users
> from inadvertently mounting the fs after an aborted run without fsck-ing.
> 
> Add field "s_tunefs_flag" in ocfs2_super_block to indicate the real reason of
> aborted tunefs.ocfs2.

Thanks for adding this Tao.

We're missing one thing though - I believe you need to add a check against
s_tunefs_flag in ocfs2_open() if the OCFS2_FLAG_STRICT_COMPAT_CHECK flag is passed. That way
fsck.ocfs2 won't try to clean up an aborted tunefs that it doesn't know
about.
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com