[Ocfs2-tools-devel] Re: ocfs2-tools/sparse-files: always print empty extent records

[tao.ma]

Mark Fasheh wrote:
> We want to be explicit in debugfs and print all extent records within
> l_next_free_rec, even empty ones.
>
> The non e_clusters fields within the record may contain interesting
> information that could be used when tracking down bugs.
>
> Additionally, it gets a little confusing if debugfs randomly starts the
> array at one or zero.
>   
OK, so do commit in the branch. sob.
> Signed-off-by: Mark Fasheh <mark.fasheh at oracle.com>
>
> Index: ocfs2-tools_sparse/debugfs.ocfs2/dump.c
> ===================================================================
> --- ocfs2-tools_sparse.orig/debugfs.ocfs2/dump.c
> +++ ocfs2-tools_sparse/debugfs.ocfs2/dump.c
> @@ -303,11 +303,6 @@ void dump_extent_list (FILE *out, struct
>  	for (i = 0; i < ext->l_next_free_rec; ++i) {
>  		rec = &(ext->l_recs[i]);
>  		clusters = ocfs2_rec_clusters(ext->l_tree_depth, rec);
> -		/* For a sparse file, we may find an empty record.
> -		 * Just skip it.
> -		 */
> -		if (!clusters)
> -			continue;
>  		fprintf(out, "\t%-2d %-11u   %-12u   %"PRIu64"\n",
>  		       	i, rec->e_cpos, clusters, rec->e_blkno);
>  	}
>