[Ocfs2-tools-devel] debugfs.ocfs2 bmap command

[Sunil Mushran]

Signed-off.

GONG Jie wrote:
> Hi, Sunil
>
> Thanks for your advice.  I've re-create the patch.
>
> On Tuesday 29 August 2006 05:52, Sunil Mushran wrote:
>   
>> Other than the ticky-tacky issues listed below, it looks good. I tested
>> this on a largish depth=0 file. Please can someone test this on a depth=1
>> file.
>>
>> 1. Fix the compiler warning.
>> commands.c: In function `do_bmap':
>> commands.c:1319: warning: suggest parentheses around && within ||
>>
>> 2. Change the help from "Calculate the logical->physical block mapping
>> for an inode" to
>> " Print the corresponding physical block# for the inode".
>>
>> 3. dump_logical_blkno() should be in dump.c (debugfs style)
>>
>> 4. Output should have a tab... like all other commands. (debugfs style)
>>
>> 5. Code should not exceed 80 chars per line. (coding style)
>>     
>
>