[Ocfs2-tools-devel] debugfs.ocfs2 bmap command

[GONG Jie]

Hi, Sunil

Thanks for your advice.  I've re-create the patch.

On Tuesday 29 August 2006 05:52, Sunil Mushran wrote:
> Other than the ticky-tacky issues listed below, it looks good. I tested
> this on a largish depth=0 file. Please can someone test this on a depth=1
> file.
>
> 1. Fix the compiler warning.
> commands.c: In function `do_bmap':
> commands.c:1319: warning: suggest parentheses around && within ||
>
> 2. Change the help from "Calculate the logical->physical block mapping
> for an inode" to
> " Print the corresponding physical block# for the inode".
>
> 3. dump_logical_blkno() should be in dump.c (debugfs style)
>
> 4. Output should have a tab... like all other commands. (debugfs style)
>
> 5. Code should not exceed 80 chars per line. (coding style)

-- 
Regards,

GONG Jie (¹¨ò¡)
Linux Engineering, Emerging Technology & Solution Development
Oracle Software Research and Development Center
Tel:    +86-10-82786289
Mobile: +86-13011102030
Email:  jie.gong at oracle.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debugfs-bmap.patch
Type: text/x-diff
Size: 4532 bytes
Desc: not available
Url : http://oss.oracle.com/pipermail/ocfs2-tools-devel/attachments/20060829/d5e11179/debugfs-bmap.bin