[Ocfs2-test-devel] [PATCH] do not import unused timing module

[Coly Li]

Marcos E. Matsunaga Wrote:
> I believe that when I first tried timing, it wasn't part of the standard
> distribution. Then I ended using time instead.
> 
> I checked the code and timing is not used anywhere. It would be ok to
> remove now.  If we need it in the future, we can add again.
> 

Thanks for your comments and review.

After committing these patches, I can start to run test cases on sles11+hae :)


> Regards,
> 
> Marcos Eduardo Matsunaga
> 

> 
> tristan.ye wrote:
>> On Mon, 2009-03-23 at 23:55 +0800, Coly Li wrote:
>>   
>>> In many python code, e.g. build_kernel.py, module timing is imported. No python
>>> module named timing can be found from openSuSE 11.1 distribution, which will
>>> cause an import error.
>>>     
>> Strange, what's the python version openSuSE 11.1 was shipping with? will
>> you check
>>
>> 1. python
>>
>> 2. import sys
>>
>> 3. str(sys.path) 
>>
>> to see if there is a timing.py existed in above path locations. 
>>
>> I personally think it would be not a grace way to get our central code
>> modified to fit a  given distro, and it may be pretty easy to get  such
>> a module from internet for your distros:-)
>>
>> The reason why I want to keep the timing module in ocfs2-test is that
>> such module provides a more accurate way to evaluate the time a process
>> executed during the test, it even reaches a microsends level.
>>
>> Anyway, Marcos is the original author, he may have some reasons to place
>> a timing module here.
>>

-- 
Coly Li
SuSE Labs