[Ocfs2-test-devel] [PATCH] do not import unused timing module

[Coly Li]

tristan.ye Wrote:
> On Mon, 2009-03-23 at 23:55 +0800, Coly Li wrote:
>> In many python code, e.g. build_kernel.py, module timing is imported. No python
>> module named timing can be found from openSuSE 11.1 distribution, which will
>> cause an import error.
> 
> Strange, what's the python version openSuSE 11.1 was shipping with? will
> you check
> 
> 1. python
> 
> 2. import sys
> 
> 3. str(sys.path) 
> 
> to see if there is a timing.py existed in above path locations. 
> 
No, I do not find it.

> I personally think it would be not a grace way to get our central code
> modified to fit a  given distro, and it may be pretty easy to get  such
> a module from internet for your distros:-)
> 

I tried, it's hard to find an on hand rpm for timing module :(

> The reason why I want to keep the timing module in ocfs2-test is that
> such module provides a more accurate way to evaluate the time a process
> executed during the test, it even reaches a microsends level.
> 

I asked another python programmer, he also answers me this. But it seems timing
is not used anywhere, so IMHO it's safe to remove it.

> Anyway, Marcos is the original author, he may have some reasons to place
> a timing module here.
> 
Yeah, I agree :) Thanks for your review.


-- 
Coly Li
SuSE Labs