[Ocfs2-test-devel] [PATCH 3/3] ocfs2-test: add nocheckdirs option to the program.

[tristan.ye]

Looks good to me:)


On Wed, 2009-02-18 at 11:18 -0800, Marcos Matsunaga wrote:
> During the execution of run_buildkernel.py, it checks for each node's
> directory size on all directories specified. This is a long and expense
> process if the test has already run once on the same nodes and directories.
> This option will skip this check, but the user must make sure the
> directories are in good condition.
> 
> This fix is useful in cases where a crash happens during the build process
> and needs to be restarted.
> 
> Signed-off-by: Marcos Matsunaga <Marcos.Matsunaga at oracle.com>
> ---
>  programs/buildkernel/run_buildkernel.py |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/programs/buildkernel/run_buildkernel.py b/programs/buildkernel/run_buildkernel.py
> index 73ba08d..494713e 100755
> --- a/programs/buildkernel/run_buildkernel.py
> +++ b/programs/buildkernel/run_buildkernel.py
> @@ -112,6 +112,7 @@ Usage = 'Usage: %prog [-c|--count count] \
>  [-i|--initialize] \
>  [-l|-logfile logfilename] \
>  [-n|--nodes nodelist] \
> +[-nocheck] \
>  [-t|--tarfile fullpath tar filename] \
>  [-u|--user username]'
>  #
> @@ -159,6 +160,12 @@ if __name__=='__main__':
>  		type='string',
>  		help='List of nodes where the test will be executed.')
>  #
> +	parser.add_option('--nocheck', 
> +		action="store_true",
> +		dest='nocheckdirs',
> +		default=False,
> +		help='Ignore directory check before the run. Default=False.')
> +#
>  	parser.add_option('-t', 
>  		'--tarfile', 
>  		dest='tarfile', 
> @@ -202,7 +209,7 @@ if DEBUGON:
>  #
>  if options.initialize:
>  	Initialize()
> -else:
> +elif not options.nocheckdirs:
>  	CheckDirs(options.nodelist, options.dirlist)
>  #
>  for i in range(options.count):