[Ocfs2-devel] [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

[Christoph Hellwig]

On Mon, Sep 28, 2015 at 01:35:38PM +0200, Andrzej Pietrasiewicz wrote:
>> -#define UVCG_STREAMING_CONTROL_SIZE	1
>
> Moving this define seems an unrelated change to me.

I can move it back - this one wasn't intentional.

>> +#define identity_conv(x) (x)
>
> What is this needed for here?
>
> This #define is not used near the place it is defined.
> Throughout the file the identity_conv is being defined multiple times,
> each time near the place it is used and then undefined.
>
> Without this line the code still compiles.

Looks like a copy & paste erro.  I'll fix it up.