[Ocfs2-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods

Christoph Hellwig hch at lst.de
Mon Sep 28 06:35:14 PDT 2015


On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> this (and the other helper below) could be macros just fine.

They could, but they shouldn't.  Inlines are always preferable over
function-like macros.

> Are you 100% compiler
> will *always* inline these helpers.

With gcc you can't ever be sure - but if it doesn't inline a trivial
pointer arithmetic we'll see breakage in various other places, including
the file system fast path which uses this pattern all over.



More information about the Ocfs2-devel mailing list