[Ocfs2-devel] Quota locking fixes for OCFS2

[Jan Kara]

On Mon 17-05-10 12:17:46, Joel Becker wrote:
> On Mon, May 17, 2010 at 06:18:01PM +0200, Jan Kara wrote:
> >   OK, will do. In the mean time I have found one more possible deadlock
> > which should be fixed by the attached patch so I'll add it to the series
> > if you won't object.
> 
> 	One question: is it possible for additional work to be added
> between the time we call the cancel and the time we take the
> dqonoff_mutex?  If it is not possible, ack on the patch and put it in
> the series.
  It isn't possible. There are only two places that queue work to this
workqueue. The first one is called when quota is being enabled (i.e., during
mount) and the second one is called from qsync_work_fn() itself. Now
cancel_delayed_work_sync() has an explicit note in the comment before it
that "It is possible to use this function if @dwork rearms itself via
queue_work() or queue_delayed_work()." so I believe everything is fine.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR