[Ocfs2-devel] [PATCH] ocfs2: prints peer node number when sending tcp msg failed

[Sunil Mushran]

Maybe what you are doing is better. One downside of doing it in
o2net_send_message_vec() is that we'll get one additional message.
And we don't want that.

But no need to add a macro. Use mlog(ML_ERROR). It will let us add
more stuff to the msg.

mlog(ML_ERROR, "Unable to send message %u (key 0x%x) to node %u\n", ...);

Sunil


Wengang Wang wrote:
> Hi Sunil,
>
> On 10-03-10 10:13, Sunil Mushran wrote:
>> Yes knowing the node number will be very useful.
>>
>> Wondering why not just have the mlog in o2net_send_message_vec().
>> Fewer changes. Do you see any downside?
>
> No very good reason just that I think there is rule that callers print
> the error number returned by the callee.
>
> If the above doesn't matter, of course your suggestion is better.
>
> Or you meant we print the errno returned by o2net_send_tcp_msg() with
> node number in o2net_send_message_vec()?
>
> regards,
> wengang.
>  
>> Wengang Wang wrote:
>>> This patch adds prints of the number of peer node to which sending tcp message
>>> failed. It helps debugging.