[Ocfs2-devel] [PATCH] ocfs2: prints peer node number when sending tcp msg failed

Wengang Wang wen.gang.wang at oracle.com
Wed Mar 10 19:21:25 PST 2010


Hi Sunil,

On 10-03-10 10:13, Sunil Mushran wrote:
> Yes knowing the node number will be very useful.
> 
> Wondering why not just have the mlog in o2net_send_message_vec().
> Fewer changes. Do you see any downside?

No very good reason just that I think there is rule that callers print
the error number returned by the callee.

If the above doesn't matter, of course your suggestion is better.

Or you meant we print the errno returned by o2net_send_tcp_msg() with
node number in o2net_send_message_vec()?

regards,
wengang.
 
> Wengang Wang wrote:
> >This patch adds prints of the number of peer node to which sending tcp message
> >failed. It helps debugging.



More information about the Ocfs2-devel mailing list