[Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.

[tristan]

Joel Becker wrote:
> On Tue, Mar 02, 2010 at 10:08:04AM +0800, tristan wrote:
>   
>> Currently 'resize.h' and 'file.h' are using ioctl structures from
>> 'ocfs2_ioctl.h', don't like 'resize.h', which only was included in
>> 'resize.c', 'file.h' instead was referred everywhere:
>>
>> We therefore need to add 'ocfs2_ioctl.h' in many C sources to avoid
>> compile warnings.
>>     
>
> 	That's right, you put it in the C sources.  This way we know
> what includes each C file has, and only the C files needing the include
> file actually include it.
>   

I'm fine with this:)

BTW, it's a bad idea to add ocfs2_ioctl.h to ocfs2.h? it's not generic 
enough to be there to let every C file refer it? right?


Tristan.


> Joel
>
>