[Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.

Joel Becker Joel.Becker at oracle.com
Mon Mar 1 18:32:17 PST 2010


On Tue, Mar 02, 2010 at 10:08:04AM +0800, tristan wrote:
> Currently 'resize.h' and 'file.h' are using ioctl structures from
> 'ocfs2_ioctl.h', don't like 'resize.h', which only was included in
> 'resize.c', 'file.h' instead was referred everywhere:
> 
> We therefore need to add 'ocfs2_ioctl.h' in many C sources to avoid
> compile warnings.

	That's right, you put it in the C sources.  This way we know
what includes each C file has, and only the C files needing the include
file actually include it.

Joel

-- 

"Every day I get up and look through the Forbes list of the richest
 people in America. If I'm not there, I go to work."
        - Robert Orben

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list