[Ocfs2-devel] [PATCH 2/3] ocfs2:freeze-thaw: initialization and cleanup

[Wengang Wang]

Hi Sunil,

On 10-01-14 18:36, Sunil Mushran wrote:
> Wengang Wang wrote:
>> if you meant ocfs2_freeze_unlock() in ocfs2_umount_volume() instead of
>> at the end of ocfs2_mount_volume(), it's NG.
>> if cleanup when umount, then we always have a ro_holder, freeze/thaw
>> doesn't work.
>>
>> and we dont need to clean it up in umount if we already cleanup it in
>> mount_volume. this is because the lock/unlock is used in pairs.
>>   
>
> What's NG?
>

NG is not good.
> And I am not following you. Don't we have to free all locks during
> umount?

we don't need to free it when we umount since we don't have that lock taken.
we lock/unlock it in mount, and in the downconvert action.

regards,
wengang.