[Ocfs2-devel] [PATCH 2/3] ocfs2:freeze-thaw: initialization and cleanup

[Sunil Mushran]

Wengang Wang wrote:
> if you meant ocfs2_freeze_unlock() in ocfs2_umount_volume() instead of
> at the end of ocfs2_mount_volume(), it's NG.
> if cleanup when umount, then we always have a ro_holder, freeze/thaw
> doesn't work.
>
> and we dont need to clean it up in umount if we already cleanup it in
> mount_volume. this is because the lock/unlock is used in pairs.
>   

What's NG?

And I am not following you. Don't we have to free all locks during
umount?