[Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3

Joel Becker Joel.Becker at oracle.com
Fri Aug 28 01:14:52 PDT 2009


On Fri, Aug 28, 2009 at 03:40:21PM +0800, Wengang Wang wrote:
> Joel Becker wrote:
> > 	Sunil is right that developers will know what was printed and
> > that we don't need to be terribly detailed about that.  I'm saying that
> > I don't know that entry/exit logs are useful.  We never turn them on
> > because they are too noisy.
> 
> 
> Ok. Then I will pick up the mlog_error()s and mlog(ERR...)s and re-post 
> later...

	Yes, that would be great.  Any time you are debugging some code
and you think "I'd really like to know this value here" or something,
feel free to add an mlog and send it in.  We appreciate it.  It's just
the entry/exit stuff we're trying to get away from.
	(Of course, if you want to start the migration to the new
generic tracepoints...)

Thanks!
Joel

-- 

"The first thing we do, let's kill all the lawyers."
                                        -Henry VI, IV:ii

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list